Better backend API #1138
Merged
Better backend API #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sort attributes as soon as a new one has been added. Signed-off-by: Paul Cercueil <[email protected]>
A backend API function iio_context_add_device() will be introduced; rename the old function so that it won't get in the way. Signed-off-by: Paul Cercueil <[email protected]>
This API function can be used to create and add a iio_device to the iio_context. Signed-off-by: Paul Cercueil <[email protected]>
buha
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
i've played with a few of these functions and they provide a good alternative to the iio_create_context_from_xml function which uses libxml2 which grows the .text area of the binary about 3 times in my tests (100k -> 300k)
what Paul did here is very good for embedding tinyiiod on small embedded devices
pcercuei
force-pushed
the
pcercuei/better-backend-api
branch
from
b4b7b92
to
e1c3a9d
Compare
This API function can be used to create and add a iio_channel to the iio_device. Signed-off-by: Paul Cercueil <[email protected]>
These functions can be used to add an attribute to an iio_context, iio_device and iio_channel respectively. Signed-off-by: Paul Cercueil <[email protected]>
Change its prototype so that it takes a iio_context_params pointer, as well as major/minor/git_tag version information. Signed-off-by: Paul Cercueil <[email protected]>
Use the new backend functions to create the iio_context, iio_device and iio_channel objects. By doing so, the XML backend is now fully decoupled from the private API, and it only uses public headers. Note that we don't need to print the channel or device names with the debug macros, as they already do that for us. Signed-off-by: Paul Cercueil <[email protected]>
Rework the code to use the new iio_context_add_device() from the backend API, instead of using Libiio's internal functions directly. Signed-off-by: Paul Cercueil <[email protected]>
This function is not used anywhere anymore. Signed-off-by: Paul Cercueil <[email protected]>
Signed-off-by: Paul Cercueil <[email protected]>
pcercuei
force-pushed
the
pcercuei/better-backend-api
branch
from
f87886f
to
6ad613a
Compare
mhennerich
approved these changes
Jan 31, 2024
|
@pcercuei you may merge this |
|
Only people from ADI can merge 🙃 |
|
Gentle ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify/add functions:
iio_context_add_device, which will create aiio_deviceand add it to the context;iio_device_add_channel, which will create aiio_channeland add it to the device;iio_{context,device,channel}_add_attrto add attributes to contexts/devices/channels are now backend APIiio_create_context_from_backendnow takes a few extra parameters that will be used to create the iio_context.With these changes, the XML backend was updated to be fully implemented on top of the public API (be it iio.h or iio-backend.h) and does not use iio-private.h anymore.
In theory, the local backend could do that too but it's a lot more work (due to how it currently creates the context).
The code should be considered very experimental, it was not thoroughly tested.