Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ad9081: common: ad9081_fmca_ebz_bd: Fix number of quads calculation #1524

Merged
merged 1 commit into from
Nov 27, 2024
Merged

ad9081: common: ad9081_fmca_ebz_bd: Fix number of quads calculation #1524

merged 1 commit into from
Nov 27, 2024

Conversation

bluncan
Copy link
Contributor

@bluncan bluncan commented Nov 22, 2024

PR Description

The old formula would result in '0' quads when L was less than 4 and would not properly connect the serial lanes to the PHY.
Replacing the round with ceil fixes that.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@bluncan
ad9081: common: ad9081_fmca_ebz_bd: Fix number of quads calculation
fb016ea 
The old formula would result in '0' quads when L was less than 4
and would not properly connect the serial lanes to the PHY.

Signed-off-by: Bogdan Luncan <[email protected]>
@bluncan bluncan added the bug label Nov 22, 2024
@bluncan bluncan merged commit 4a5213f into main Nov 27, 2024
3 of 4 checks passed
@bluncan bluncan deleted the versal_ad9081_fix_quad_calculation branch November 27, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acostina acostina acostina approved these changes

@IuliaCMoldovan IuliaCMoldovan Awaiting requested review from IuliaCMoldovan IuliaCMoldovan is a code owner

@AndrDragomir AndrDragomir Awaiting requested review from AndrDragomir AndrDragomir is a code owner

@FilipG24 FilipG24 Awaiting requested review from FilipG24 FilipG24 is a code owner

@LBFFilho LBFFilho Awaiting requested review from LBFFilho LBFFilho is a code owner

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bluncan @acostina