Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

axi_dmac: Fixup _hw.tcl variables names #1523

Merged
merged 1 commit into from
Nov 28, 2024
Merged

axi_dmac: Fixup _hw.tcl variables names #1523

merged 1 commit into from
Nov 28, 2024

Conversation

gastmaier
Copy link
Contributor

PR Description

Update ENABLE_FRAMELOCK to FRAMELOCK.
Update reg_defaults to defaults.
Fixup for each.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@gastmaier
axi_dmac: Fixup _hw.tcl variables names
db6c067 
Update ENABLE_FRAMELOCK to FRAMELOCK.
Update reg_defaults to defaults.
Fixup for each.

Signed-off-by: Jorge Marques <[email protected]>
@gastmaier gastmaier marked this pull request as ready for review November 20, 2024 15:55
@gastmaier gastmaier mentioned this pull request Nov 22, 2024
Open
12 tasks
@bia1708
Copy link
Collaborator

bia1708 commented Nov 25, 2024

RetriggerCI

@gastmaier
Copy link
Contributor Author

gastmaier commented Nov 27, 2024 •
edited
Loading

The CI is (still) running, but the projects are succeeding.
Hopefully we have it on main before the weekend and have the pipeline normalized until monday, with the main CI resolving during the weekend.

@gastmaier
Copy link
Contributor Author

Runs look good, merging

@gastmaier gastmaier merged commit 9e3c7d6 into main Nov 28, 2024
3 of 5 checks passed
@gastmaier gastmaier deleted the dmac_hw_fix branch November 28, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@podgori podgori podgori approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gastmaier @bia1708 @podgori