Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portable versions of NativeMessageHandler and NativeCookieHandler #189

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ncruces
Copy link

@ncruces ncruces commented Oct 17, 2015

This is a first try at fixing #188. Adapted from #175.

NativeCookieHandler mostly works, though API mismatches forces us to jump through some hoops.
I based this off #187, which I think is a good idea?

NativeMessageHandler still has some gaps:

  • throwOnCaptiveNetwork works;
  • customSSLVerification doesn't seem to require anything special;
  • DisableCaching would require inheriting from WebRequestHandler which isn't portable (full .NET only);
  • RegisterForProgress is yet to be done.

Any feedback would be greatly appreciated.

@ncruces
Copy link
Author

ncruces commented Nov 17, 2015

Any interest in me further pursuing this?

NativeCookieHandler, which is what I needed, is done.
RegisterForProgress, I could do, if requested.
DisableCaching requires the approach rejected in #175.

@CliffCawley
Copy link

I'd like to see this officially supported. Right now I can't just drop in NativeMessageHandler instead of HttpClientHandler because the CookieContainer contents are ignored by NativeMessageHandler and I need to send cookies with my request. (Using with Xamarin iOS/Android)

@jamesqo
Copy link

jamesqo commented Jan 29, 2016

+1, I think this is a great idea as well. This would allow the handlers to be used reliably in PCLs without any fear of breaking for Windows clients, while providing the speed benefits when possible on iOS/Android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants