Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

after click on hamburger icons cross icon needs to align properly #639 #642

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

kapilG0
Copy link
Contributor

@kapilG0 kapilG0 commented May 20, 2024

Description

previously hamburger icon not showing properly now showing properly.

Pull Request Checklist

Please make sure that your PR meets the following requirements:

  • The app is working correctly after applying the changes.
  • The app is responsive and displays properly on different screen sizes and devices.
  • The changes are thoroughly documented in the appropriate files or documentation sections.
  • The coding conventions and style guidelines are followed consistently.

Checklist

Please check all applicable boxes and provide any additional information if needed.

  • I have tested the changes locally and ensured that the app is functioning as expected.
  • I have verified that the app is responsive and looks good on various screen sizes and devices.
  • I have reviewed the documentation and ensured that it accurately reflects the changes made.
  • I have followed the coding conventions and style guidelines defined in the project.
  • I have run the automated tests and all of them pass.
  • I have considered the performance implications of the changes made.
  • I have considered the security implications of the changes made.
  • I have checked for any potential regressions or side effects caused by the changes.
  • I have performed a self-review of my code.
  • Starred the repository.
  • Added My Name to the Contributor's List.
  • Followed the repository's Contributing Guidelines.
  • I ran the app and tested it locally to verify that it works as expected.

Screenshots - If Any (Optional)

Additional Notes(Optional)

Please provide any additional information or context that may be helpful for reviewing the pull request.

Related Issues

Please list any related issues or pull requests that are associated with this pull request.

Reviewers

@Ja3mamtora Please review this pr i have fixed the issue. Thank you

Copy link

vercel bot commented May 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
project-amupedia ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2024 2:00pm

Copy link

coderabbitai bot commented May 20, 2024

Walkthrough

Walkthrough

The recent changes focused on refining the user experience of the navigation bar. The CSS animation for the hamburger icon now rotates more smoothly with a 180-degree adjustment. Additionally, the color shift within the Navbar component enhances visual contrast and interaction feedback.

Changes

File Change Summary
styles/Navbar.module.css Adjusted the rotation angle in the CSS animation from rotate(200deg) to rotate(180deg) for the hamburger icon.
components/common/Navbar.js Modified the color attribute in the style object based on the dropdown state, switching from white to black. Also altered the style attribute in the label element to change color to black.

Poem

In the realm where code and style entwine,
The navbar's dance now more divine.
A twist from two to one-eighty fair,
Black hues now in the coder's lair.
Click and see, a sight so neat,
A coder's joy, a pixel's beat.
🐰✨

Tip

New Features and Improvements

Review Settings

Introduced new personality profiles for code reviews. Users can now select between "Chill" and "Assertive" review tones to tailor feedback styles according to their preferences. The "Assertive" profile posts more comments and nitpicks the code more aggressively, while the "Chill" profile is more relaxed and posts fewer comments.

AST-based Instructions

CodeRabbit offers customizing reviews based on the Abstract Syntax Tree (AST) pattern matching. Read more about AST-based instructions in the documentation.

Community-driven AST-based Rules

We are kicking off a community-driven initiative to create and share AST-based rules. Users can now contribute their AST-based rules to detect security vulnerabilities, code smells, and anti-patterns. Please see the ast-grep-essentials repository for more information.

New Static Analysis Tools

We are continually expanding our support for static analysis tools. We have added support for biome, hadolint, and ast-grep. Update the settings in your .coderabbit.yaml file or head over to the settings page to enable or disable the tools you want to use.

Tone Settings

Users can now customize CodeRabbit to review code in the style of their favorite characters or personalities. Here are some of our favorite examples:

  • Mr. T: "You must talk like Mr. T in all your code reviews. I pity the fool who doesn't!"
  • Pirate: "Arr, matey! Ye must talk like a pirate in all yer code reviews. Yarrr!"
  • Snarky: "You must be snarky in all your code reviews. Snark, snark, snark!"

Revamped Settings Page

We have redesigned the settings page for a more intuitive layout, enabling users to find and adjust settings quickly. This change was long overdue; it not only improves the user experience but also allows our development team to add more settings in the future with ease. Going forward, the changes to .coderabbit.yaml will be reflected in the settings page, and vice versa.

Miscellaneous

  • Turn off free summarization: You can switch off free summarization of PRs opened by users not on a paid plan using the enable_free_tier setting.
  • Knowledge-base scope: You can now set the scope of the knowledge base to either the repository (local) or the organization (global) level using the knowledge_base setting. In addition, you can specify Jira project keys and Linear team keys to limit the knowledge base scope for those integrations.
  • High-level summary placement: You can now customize the location of the high-level summary in the PR description using the high_level_summary_placeholder setting (default @coderabbitai summary).
  • Revamped request changes workflow: You can now configure CodeRabbit to auto-approve or request changes on PRs based on the review feedback using the request_changes_workflow setting.

Warning

Review ran into problems

Problems (1)
  • Git: Failed to clone repository. Please contact CodeRabbit support.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Thank you, @kapilG0, for creating this pull request and contributing to GitHub-ReadMe! 💗

Our review team will thoroughly review the pull request and will reach out to you soon! 😇
Please make sure you have marked all the completed tasks as done. ✅
We appreciate your patience and contribution! 😀

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between c5f45df and a1a1cc2.
Files selected for processing (1)
  • styles/Navbar.module.css (1 hunks)
Files skipped from review due to trivial changes (1)
  • styles/Navbar.module.css

@kapilG0
Copy link
Contributor Author

kapilG0 commented May 22, 2024

Hello @Ja3mamtora can you please review this pr and let me know if any modifications required thank you

@Ja3mamtora
Copy link
Collaborator

@kapilG0 attach screenshot

@kapilG0
Copy link
Contributor Author

kapilG0 commented May 22, 2024

@kapilG0 attach screenshot

Hello @Ja3mamtora . Please check i am attaching screen shot
image

@Ja3mamtora
Copy link
Collaborator

image
the hamburger icon is not visible

@kapilG0
Copy link
Contributor Author

kapilG0 commented May 23, 2024

image the hamburger icon is not visible

When I cloned that code that issue I was also getting but if you will click on right top you will see list and cross icon. I need to check why it is happening but cross icon has fixed please click on top right corner

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between a1a1cc2 and cca69e8.
Files selected for processing (1)
  • components/common/Navbar.js (1 hunks)
Files skipped from review due to trivial changes (1)
  • components/common/Navbar.js

@kapilG0
Copy link
Contributor Author

kapilG0 commented May 24, 2024

Hello @Ja3mamtora i have fixed that issue also as you told hamburger not visible cca69e8 this is pull request . please check

@kapilG0
Copy link
Contributor Author

kapilG0 commented May 27, 2024

Hello @Ja3mamtora i have fixed that now' icon is showing please check and let me know if any modifications required

1 similar comment
@kapilG0
Copy link
Contributor Author

kapilG0 commented Jun 3, 2024

Hello @Ja3mamtora i have fixed that now' icon is showing please check and let me know if any modifications required

@Ja3mamtora Ja3mamtora merged commit 443051a into amupedia2021:develop Jun 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants