Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I made changes in dropdown menu and made "BE" Link working. #622

Closed
wants to merge 1 commit into from

Conversation

rahul803213
Copy link

@rahul803213 rahul803213 commented May 12, 2024

Fix #619

Description

  1. I made changes in DropDown menu and corrected its background color so that it not create any visibility issue.
  2. Previously "BE" link was not working so i created a folder "BE" in pages and made index.js and write the content for the page.Now its behaviour is correct.

Pull Request Checklist

Please make sure that your PR meets the following requirements:

  • [ ✅] The app is working correctly after applying the changes.
  • [ ✅] The app is responsive and displays properly on different screen sizes and devices.
  • [ ✅] The changes are thoroughly documented in the appropriate files or documentation sections.
  • [✅ ] The coding conventions and style guidelines are followed consistently.

Checklist

Please check all applicable boxes and provide any additional information if needed.

  • [ ✅] I have tested the changes locally and ensured that the app is functioning as expected.
  • [✅ ] I have verified that the app is responsive and looks good on various screen sizes and devices.
  • [ ✅] I have reviewed the documentation and ensured that it accurately reflects the changes made.
  • [✅ ] I have followed the coding conventions and style guidelines defined in the project.
  • [ ✅] I have run the automated tests and all of them pass.
  • [ ✅] I have considered the performance implications of the changes made.
  • [ ✅] I have considered the security implications of the changes made.
  • [ ✅] I have checked for any potential regressions or side effects caused by the changes.
  • [ ✅] I have performed a self-review of my code.
  • [✅ ] Starred the repository.
  • [✅ ] Added My Name to the Contributor's List.
  • [✅ ] Followed the repository's Contributing Guidelines.
  • [ ✅] I ran the app and tested it locally to verify that it works as expected.

Screenshots - If Any (Optional)

Screenshot 2024-05-12 at 4 04 06 PM Screenshot 2024-05-12 at 4 04 24 PM

Additional Notes(Optional)

Please provide any additional information or context that may be helpful for reviewing the pull request.

Related Issues

Please list any related issues or pull requests that are associated with this pull request.

Reviewers

Please tag the relevant team members or reviewers who should review this pull request.

Copy link

vercel bot commented May 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
project-amupedia ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 12, 2024 10:37am

Copy link

coderabbitai bot commented May 12, 2024

Walkthrough

Walkthrough

The latest update brings a significant navigation change in the Navbar.js, redirecting from the home page to a new Bachelor of Engineering (BE) course page. This page is now fully set up with relevant content and links. Additionally, aesthetic updates have been made to the Navbar's style, enhancing its visual appeal with new colors and effects.

Changes

File Path Change Summary
components/.../Navbar.js Updated link destination from home to BE courses.
pages/courses/be/index.js Added new BE course page with content and layout components.
styles/.../Navbar.module.css Updated styles including background color, border-radius, text color changes, and hover effects.

🐰✨
In the code's weave, a change we interlace,
From home to courses, a new learning space.
Colors shift, like dawn to dusk,
A navbar's hue, a page's musk.
Hop along on paths anew,
With code lines fresh and errors few. 🌟
🐰💻


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Thank you, @rahul803213, for creating this pull request and contributing to GitHub-ReadMe! 💗

Our review team will thoroughly review the pull request and will reach out to you soon! 😇
Please make sure you have marked all the completed tasks as done. ✅
We appreciate your patience and contribution! 😀

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between c5f45df and 54e20e7.
Files selected for processing (3)
  • components/common/Navbar.js (1 hunks)
  • pages/courses/be/index.js (1 hunks)
  • styles/Navbar.module.css (3 hunks)
Files skipped from review due to trivial changes (1)
  • pages/courses/be/index.js
Additional comments not posted (4)
styles/Navbar.module.css (3)

148-148: The new background color for the dropdown menu enhances visibility and aligns with the PR's objectives.


158-158: The updated border-radius for list items in the dropdown menu contributes to a more modern and appealing visual design.


168-170: The enhanced hover effects for list items in the dropdown menu provide a more dynamic user interaction experience.

components/common/Navbar.js (1)

228-228: The update to the "BE" link in the dropdown menu correctly directs users to the new BE courses page, aligning with the PR's objectives.

Verification successful

The review of the Navbar.js file confirms the presence of the link <Link href='/courses/be'> within a dropdown menu for courses. This aligns with the PR's objectives to update the navigation link for "BE" courses, ensuring users are directed to the correct page.

  • The link is correctly implemented in the dropdown menu under the "Courses" section.
  • It is designed to close the dropdown upon clicking, which is a good UX practice.

This verification confirms that the update is correctly implemented as per the PR's description.

Scripts Executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify that the "BE" link correctly redirects to the intended page.

# Test: Search for the "BE" link usage. Expect: Only occurrences of the new link.
rg --type javascript $'Link href="/courses/be"'

Length of output: 83



Script:

#!/bin/bash
# Description: Verify that the "BE" link correctly redirects to the intended page.

# Test: Search for the "BE" link usage across all files. Expect: Only occurrences of the new link.
rg 'Link href="/courses/be"'

Length of output: 30



Script:

#!/bin/bash
# Description: Manually verify the presence of the "BE" link in the specific file mentioned in the review.

# Test: Display the contents of the file where the "BE" link is supposed to be.
cat components/common/Navbar.js

Length of output: 11627

@rahul803213 rahul803213 deleted the branch amupedia2021:develop May 12, 2024 16:51
@rahul803213 rahul803213 deleted the develop branch May 12, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 [BUG] - Background of courses dropdown menu is transparent and creating visibility problem.
1 participant