-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker file is added #414
base: master
Are you sure you want to change the base?
Docker file is added #414
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you, @shraddha761, for creating this pull request and contributing to GitHub-ReadMe! 💗 Our review team will thoroughly review the pull request and will reach out to you soon! 😇 |
@anmode please have a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please attach the build image size , and image details with successful build
FROM node:slim | ||
|
||
WORKDIR /app | ||
|
||
COPY . /app | ||
|
||
RUN npm install | ||
|
||
EXPOSE 3000 | ||
|
||
CMD npm start |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you copy only build files at last? Do use multistage build.
Description
Issue reference - #160
Please provide a brief description of the changes introduced in this pull request. Explain the problem you are solving or the feature you are adding.
Pull Request Checklist
Please make sure that your PR meets the following requirements:
Checklist
Please check all applicable boxes and provide any additional information if needed.
Screenshots - If Any (Optional)
Additional Notes(Optional)
Please provide any additional information or context that may be helpful for reviewing the pull request.
Related Issues
Please list any related issues or pull requests that are associated with this pull request.
Reviewers
Please tag the relevant team members or reviewers who should review this pull request.