Added internship page [GSSoC'23]] #410
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thank you, @brohithkr, for creating this pull request and contributing to GitHub-ReadMe! 💗 Our review team will thoroughly review the pull request and will reach out to you soon! 😇 |
anmode
requested changes
Jun 13, 2023
Comment on lines
-32
to
-41
|
|
||
| export const getServerSideProps = async () => { | ||
| const data = await fetch("http://localhost:3000/api/opportunities/fetchOpportunities"); | ||
| const result = await data.json(); | ||
| return { | ||
| props: { | ||
| result | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
why? please see the api...if there may be some problem
Comment on lines
+1
to
+7
| let i = 0; | ||
| const internshipData = [ | ||
| { | ||
| "id": i++, | ||
| "image": "", | ||
| "title": "Software Engineering", | ||
| "date": "12 August 2023", |
There was a problem hiding this comment.
for starting card we can have these... but we have to fetch it live... could you please see if any api available. other wise we will populate data from the database.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an Internship page and added an Opportunities section in Navbar. Populated the OppCard in internship page using json data.
Pull Request Checklist
Please make sure that your PR meets the following requirements:
Checklist
Please check all applicable boxes and provide any additional information if needed.
Screenshots
Related Issues
The fetchOpportunities api is not working propperly.
Reviewers
@anmode