fix(heartbeat): stop heartbeat if connection is not active

[slavik-pastushenko]

Fixed #401

If you stop your RabbitMQ cluster with a grace period 0, it will still say it is connected.

By sending a readable event it returns:

2024-04-22T16:23:32.570945Z ERROR Socket was readable but we read 0. This usually means that the connection is half closed which marks it as broken.

[Keruspe]

We shouldn't emit a readable event ourselves, it really should come from the socket itself.

It can be a good lead for investigation though (and I have plan for an overhaul of all of this btw).

Do you use TLS or plain tcp ?

[slavik-pastushenko]

We shouldn't emit a readable event ourselves, it really should come from the socket itself.

It can be a good lead for investigation though (and I have plan for an overhaul of all of this btw).

Do you use TLS or plain tcp ?

plain TCP, lemme update the pr

[slavik-pastushenko]

@Keruspe PR is updated.

[Keruspe]

I like that last commit. When dumping #404 and letting it rest in my head I thought of something similar.

There's a couple of things that should be updated though.

I think we should have a dedicated error for this.

The check should be done at the very beginning of the self.timeout.map block, we should use cancel there and return None. We should check for 4*timeout (see comment in #404)

[Keruspe]

Mostly LGTM, will fixup a couple of cosmetic stuff and issue a release