Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏗⏪ Revert workaround for setting CHROME_VERSION in CircleCI #40202

Closed
wants to merge 1 commit into from
Closed

🏗⏪ Revert workaround for setting CHROME_VERSION in CircleCI #40202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
version: 2.1

orbs:
browser-tools: circleci/[email protected].8
browser-tools: circleci/[email protected].9
codecov: codecov/[email protected]
macos: circleci/[email protected]
node: circleci/[email protected]
Expand Down Expand Up @@ -174,7 +174,7 @@ commands:
name: '💿 Update list of available apt packages'
command: sudo apt update
- browser-tools/install-chrome:
# chrome-version is set in ./.circleci/get_pinned_chrome_version.sh, see files for details.
chrome-version: ${CHROME_VERSION}
replace-existing: true
- browser-tools/install-chromedriver
install_firefox:
Expand Down
4 changes: 0 additions & 4 deletions .circleci/get_pinned_chrome_version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,3 @@ echo "$(GREEN "Chrome version history URL is") $(CYAN "${CHROME_VERSION_HISTORY_
echo "$(GREEN "Determining Chrome version...")"
CHROME_VERSION="$(curl -sS --retry 3 ${CHROME_VERSION_HISTORY_URL} | jq -r ".versions[]|.version" | grep -m 1 "${CHROME_MAJOR_VERSION}\.[[:digit:]]\+.[[:digit:]]\+.[[:digit:]]\+")"
echo "$(GREEN "Chrome version is") $(CYAN "${CHROME_VERSION}")"

# Workaround for https://github.com/CircleCI-Public/browser-tools-orb/issues/70
echo "export ORB_PARAM_CHROME_VERSION=$CHROME_VERSION" >> $BASH_ENV
echo $(GREEN "Successfully determined pinned version of Chrome")
Loading