Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Update path for openadstream ads url #40091

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

HJK51
Copy link

@HJK51 HJK51 commented Jul 17, 2024

You can add the url path of the OAS ad tag.

References:

  • AMP code contribution docs: go.amp.dev/contribute/code
  • First time setup (required for CI checks): go.amp.dev/getting-started

make url path for ads tag
add path for ads tag url
@CLAassistant
Copy link

CLAassistant commented Jul 17, 2024

CLA assistant check
All committers have signed the CLA.

@erwinmombay
Copy link
Member

@powerivq could you take a look at this?

@@ -1,19 +1,19 @@
import {validateData, writeScript} from '#3p/3p';
import {validateData, writeScript } from '#3p/3p';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: space

@powerivq
Copy link
Contributor

Hey @HJK51 can you change that to fix the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants