Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PostFeaturedImage to PrePublishPanel #6563

6 changes: 1 addition & 5 deletions assets/src/block-editor/plugins/pre-publish-panel.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,12 @@
* Internal dependencies
*/
import { PrePublishPanel } from '../../common/components';
import { getMinimumFeaturedImageDimensions } from '../../common/helpers';

export const name = 'amp-post-featured-image-pre-publish-panel';

// On clicking 'Publish,' display a notice if no featured image exists or its width is too small.
export const render = () => {
return (
<PrePublishPanel
dimensions={ getMinimumFeaturedImageDimensions() }
required={ false }
/>
<PrePublishPanel />
);
};
59 changes: 6 additions & 53 deletions assets/src/common/components/pre-publish-panel.js
Original file line number Diff line number Diff line change
@@ -1,73 +1,26 @@
/**
* External dependencies
*/
import PropTypes from 'prop-types';

/**
* WordPress dependencies
*/
import { Notice } from '@wordpress/components';
import { PostFeaturedImage } from '@wordpress/editor';
import { PluginPrePublishPanel } from '@wordpress/edit-post';
import { withSelect } from '@wordpress/data';
import { __ } from '@wordpress/i18n';

/**
* Internal dependencies
*/
import { validateFeaturedImage } from '../helpers';

/**
* Conditionally adds a notice to the pre-publish panel for the featured image.
* Adds a notice to the pre-publish panel for the featured image.
pierlon marked this conversation as resolved.
Show resolved Hide resolved
*
* @param {Object} props Component props.
* @param {Object} props.featuredMedia Media object.
* @param {Array} props.dimensions Required image dimensions.
* @param {boolean} props.required Whether selecting a featured image is required.
* @return {Function} Either a plain pre-publish panel, or the panel with a featured image notice.
pierlon marked this conversation as resolved.
Show resolved Hide resolved
*/
const PrePublishPanel = ( { featuredMedia, dimensions, required } ) => {
const errors = validateFeaturedImage( featuredMedia, dimensions, required );

if ( ! errors ) {
return null;
}

const PrePublishPanel = () => {
return (
<PluginPrePublishPanel
title={ __( 'Featured Image', 'amp' ) }
initialOpen="true"
>
<Notice
status={ required ? 'warning' : 'notice' }
isDismissible={ false }
>
{ errors.map( ( errorMessage, index ) => {
return (
<p key={ `error-${ index }` }>
{ errorMessage }
</p>
);
} ) }
</Notice>
<PostFeaturedImage />
</PluginPrePublishPanel>
);
};

PrePublishPanel.propTypes = {
featuredMedia: PropTypes.object,
dimensions: PropTypes.shape( {
width: PropTypes.number.isRequired,
height: PropTypes.number.isRequired,
} ),
required: PropTypes.bool,
};

export default withSelect( ( select ) => {
const currentPost = select( 'core/editor' ).getCurrentPost();
const editedFeaturedMedia = select( 'core/editor' ).getEditedPostAttribute( 'featured_media' );
const featuredMedia = currentPost.featured_media || editedFeaturedMedia;
PrePublishPanel.propTypes = {};
pierlon marked this conversation as resolved.
Show resolved Hide resolved

return {
featuredMedia: featuredMedia ? select( 'core' ).getMedia( featuredMedia ) : null,
};
} )( PrePublishPanel );
export default PrePublishPanel;
Loading