Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve check-url command output #3929

Open
wants to merge 5 commits into
base: update/amp-validate-requests
Choose a base branch
from
Open

Improve check-url command output #3929

wants to merge 5 commits into from

Commits on Dec 16, 2019

  1. Improve check-url command output 

    Adds the following:
- multiple output formats that can be selected via `--format=<format>`: `json`, `yaml`, `table`, `count`
- tabular format improves output for human consumption
- adds filtering via `--<field>=<value>`
- allows selection of fields to display via `--fields=<fields>`
- can return a single column via `--field=<field>`
- uses exit codes for scripting purposes
    @schlessera
    schlessera committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    1fb34aa View commit details
    Browse the repository at this point in the history

  2. Deal with differing field combinations

    @schlessera
    schlessera committed Dec 16, 2019
    Configuration menu
    Copy the full SHA
    c28efee View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2019

  1. Add test for get_validation_error_fields()

    @schlessera
    schlessera committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    29b2292 View commit details
    Browse the repository at this point in the history

  2. Add test for pad_validation_error_fields()

    @schlessera
    schlessera committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    ee95baf View commit details
    Browse the repository at this point in the history

  3. Add non-hooked function logic

    @schlessera
    schlessera committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    6720d3e View commit details
    Browse the repository at this point in the history