Prevent tree-shaking tag/ID selectors for amp-lightbox-gallery #3226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
force-pushed
the
fix/amp-lightbox-gallery-tree-shaking
branch
from
afd5014
to
2ca646f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #4595.
This PR prevents that tree-shaking from happening, but it's not clear yet whether this element should be styled in the first place, since the docs page does not provide any Styling guidance as do other components' docs pages.
Nevertheless, it is likely that there could be other components that behave similarly, and so the tree shaker should still be extended to guard against removal of style rules for dynamically-added elements and IDs.
Build for testing: amp.zip - v1.3-alpha-20190911T183957Z-2ca646fa