Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/trit 582 implement sdk compatibility for custom sorts #108

Merged

Conversation

AEmberson
Copy link
Contributor

@AEmberson AEmberson commented Oct 24, 2024

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests (npm run test) for the changes have been added (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Docs (npm run doc) have been reviewed and added / updated if needed (for bug fixes / features)
  • PR title and git commit messages conform to the conventionalcommits specification

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Hierarchies is supported but sorting outside of the default is not.

What is the new behavior?

This change exposes the new parameters in the hierarchies endpoint for custom sort.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@coveralls
Copy link

coveralls commented Oct 24, 2024

Pull Request Test Coverage Report for Build 11499289073

Details

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 93.307%

Totals Coverage Status
Change from base Build 11480383745: 0.05%
Covered Lines: 818
Relevant Lines: 849

💛 - Coveralls

@labski42 labski42 merged commit a23259a into master Oct 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants