Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cycles in enhanced graph #173

Open
nschneid opened this issue Oct 31, 2023 · 2 comments
Open

Cycles in enhanced graph #173

nschneid opened this issue Oct 31, 2023 · 2 comments

Comments

@nschneid
Copy link
Contributor

# relative in embedded PP ("to which","whose" -- whose would also need action #3~#1;#1:edep=nmod:poss; but this creates a cycle)

# exception to previous: prevent cycle when acl:relcl head has a coordinate predicate

These comments reference avoiding making the graph cyclic, but I think cycles are actually OK, as mentioned here. We just want to avoid self-edges.

@amir-zeldes
Copy link
Owner

amir-zeldes commented Oct 31, 2023

In principle, yes, the edeps specification allows cycles. In practice though, ANNIS can't handle cycles in the same component, which is a somewhat complicated construct to explain. The basic gist is that cycles between regular deps and edeps are fine, but not within one of them. Since the build bot doesn't materialize edeps which are identical to basic deps, we can largely get away with edeps as intended. The few exceptions are the ones noted in the script, and currently GUM edeps lack those edges in conllu as well. Moving forward it would probably be nice to have these in conllu and either remove them before it goes to ANNIS, or find a different way to represent them (e.g. have another layer "edeps2" or something, which would be allowed to conflict with other edeps, or use a label instead of an edge somehow)

@nschneid
Copy link
Contributor Author

Moving forward it would probably be nice to have these in conllu and either remove them before it goes to ANNIS, or find a different way to represent them

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants