Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sensors to mujoco ergoCub #6

Open
2 of 5 tasks
giotherobot opened this issue Mar 6, 2024 · 8 comments
Open
2 of 5 tasks

Add sensors to mujoco ergoCub #6

giotherobot opened this issue Mar 6, 2024 · 8 comments
Assignees

Comments

@giotherobot
Copy link
Member

giotherobot commented Mar 6, 2024

Sensors

@giotherobot giotherobot self-assigned this Mar 6, 2024
@giotherobot
Copy link
Member Author

Trying to add the FT sensors programmatically I found an issue in the converted model: the fixed joints that in the URDF represent the FT location are not present in the MJCF model converted. It seems that the fixed joint gets removed in the processing, the chain does not contain a 'l_shoulder_3link for example and the connection is direct froml_shoulder_2tol_upper_arm. Both meshes ("sim_ecub_1-1_l_shoulder_2" and "sim_ecub_1-1_l_shoulder_3") are loaded into the l_shoulder_2` link.

@giotherobot
Copy link
Member Author

@traversaro
Copy link
Contributor

Ah cool, that was exactly the first issue we faced when importing the iCub in Gazebo Classic in 2013 as well, we solved it back in time by adding an option to disable fixed joint lumping gazebosim/sdformat@62e8dd0 and https://osrf-migration.github.io/sdformat-gh-pages/#!/osrf/sdformat/pull-requests/133/page/1 . We could think of ignoring FT sensors for now.

@giotherobot
Copy link
Member Author

Ok let's skip FTs for now, looking at mujoco there seems to be no 'fixed' joint too.

@giotherobot
Copy link
Member Author

The same problem is present with IMUs, to place them in the URDF we are using fixed joints that vanish in the conversion to mjcf.

I think the "correct" way to deal with these should be with site elements (see https://mujoco.readthedocs.io/en/stable/XMLreference.html#body-site).

@traversaro
Copy link
Contributor

The same problem is present with IMUs, to place them in the URDF we are using fixed joints that vanish in the conversion to mjcf.

I think the "correct" way to deal with these should be with site elements (see https://mujoco.readthedocs.io/en/stable/XMLreference.html#body-site).

Nice, also for this we have a Gazebo equivalent: gazebosim/sdformat#262, that then was fixed in gazebosim/sdformat#1148 .

@giotherobot
Copy link
Member Author

@vpunithreddy is working on this for ironcub on the https://github.com/ami-iit/mujoco-urdf-loader repo, we can open issues there.

@giotherobot giotherobot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 17, 2024
@giotherobot giotherobot transferred this issue from another repository Jul 17, 2024
@giotherobot giotherobot reopened this Jul 17, 2024
@vpunithreddy
Copy link
Collaborator

vpunithreddy commented Jul 17, 2024

Thanks @giotherobot
I have started to add sites necessary for the frames of the sensors with respect to their parent_body

I have used iRoncub-Mk3 for reference and have been progressing.
As of now, I have added the

  • FT sites
  • IMU sites
    I need to add the sensors using these sites.

The commits are in the branch iRonCub_mjcf

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants