-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add dropdown for layout thoroughness selection #620
base: main
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,6 +24,8 @@ import { | |
Divider, | ||
Drawer, | ||
IconButton, | ||
Select, | ||
MenuItem, | ||
List, | ||
ListItem, | ||
ListItemIcon, | ||
|
@@ -345,32 +347,36 @@ export const MoreActionsDrawer = ({ | |
<ListItem disablePadding={false}> | ||
<Typography variant="body2">Layout Thoroughness</Typography> | ||
<Tooltip | ||
title="Determines how much effort the layout algorithm puts into laying out nodes such that they efficiently use space. 1 = lowest effort, 100 = highest effort." | ||
title="Determines how much effort the layout algorithm puts into laying out nodes such that they efficiently use space. Low = minimal effort, High = maximum effort." | ||
enterTouchDelay={0} // allow touch to immediately trigger | ||
leaveTouchDelay={Infinity} // touch-away to close on mobile, since message is long | ||
> | ||
<IconButton | ||
color="info" | ||
aria-label="Thoroughness info" | ||
sx={{ | ||
// Don't make it look like clicking will do something, since it won't. | ||
// Using a button here is an attempt to make it accessible, since the tooltip will show | ||
// on focus. | ||
cursor: "default", | ||
cursor: "default", // Maintain accessibility while preventing click actions | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this comment makes it seem like setting Side note: looking at this code again, it seems like we could just add a tabIndex to allow focus on the icon directly, instead of adding a button for that. I'm not sure why I didn't do that. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please keep the previous explanation here, it's still relevant |
||
alignSelf: "center", | ||
}} | ||
> | ||
<Info /> | ||
</IconButton> | ||
</Tooltip> | ||
<NumberInput | ||
min={1} | ||
max={100} | ||
<Select | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Like with the watch dropdown, I would have used Mui's I think using |
||
value={layoutThoroughness} | ||
onChange={(_event, value) => { | ||
if (value) setLayoutThoroughness(value); | ||
onChange={(event) => { | ||
const value = event.target.value; | ||
setLayoutThoroughness(Number(value)); | ||
}} | ||
keyserj marked this conversation as resolved.
Show resolved
Hide resolved
|
||
/> | ||
sx={{ | ||
marginLeft: "16px", | ||
minWidth: "120px", | ||
}} | ||
keyserj marked this conversation as resolved.
Show resolved
Hide resolved
|
||
> | ||
<MenuItem value={1}>Low</MenuItem> | ||
<MenuItem value={10}>Medium</MenuItem> | ||
<MenuItem value={100}>High</MenuItem> | ||
</Select> | ||
</ListItem> | ||
|
||
<Divider>Filter Config</Divider> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned here https://github.com/amelioro/ameliorate/pull/620/files#r1894997107, since we're using
Select
still, we should removeLayout
to keep this text from having to wrap to two lines.