Mitigation node #609
Merged
Mitigation node #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitigations are smaller/lower-focus than regular solutions, and so their effects should be able to lay out wherever.
not really sure what's best here, but this is following the logic of showing pieces of the selected solution. currently, mitigations aren't considered a piece of the selected solution, so they aren't shown in the filter.
✅ Deploy Preview for ameliorate-docs canceled.
|
✅ Deploy Preview for velvety-vacherin-4193fb ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #549
Not really sure if the extra complexity of Mitigation is worth it. The main value seems that we can treat mitigations as secondary/not-core, whereas solutions are core nodes and should stand out more. But there could be confusion about how to use mitigations, since solutions can accomplish a similar purpose.
We'll have to keep an eye out for how these feel - whether or not they seem worth the separate node type and logic.
Description of changes
Additional context