Update from upstream #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add basic benchmark reporting to CI
This enables keep alive on tcp sockets via keep-alive feature.
The choices were based on the request_policy tip from the COMMAND output.
Trying to avoid bumping MSRV to 1.63 just for a dev dependency.
This caused panics when the node was in the wrong state.
This will give us more data on test failure.
This adds ~10 minutes to previous test run time, in order to leave a comfortable margin, while still significantly reducing the run time of the task in case it gets stuck. Without defining this, the task runs for 6 hours.
* Release redis 0.23.2 / redis-test 0.2.2 * Update rust version for CI, due to tokio update. * Update rust-version in cargo.toml. * Fix lints.
The extern crate statement used to be an important part of rust, several years ago. These days it's a point of confusion for newcomers without adding any value, and should be omitted.
The test was broken by version 1.0.105 of serde_json, due to serde-rs/json#1055 .
* Add NOTBUSY error code. * async cluster: Group responses by response_policy. This change implements the response_policy tip in the async cluster. https://redis.io/docs/reference/command-tips/#response_policy This means that the results from fan-out commands will be aggregated differently, based on the sent command.
* Determine the type of a key * modify the name of the function for determining the type of a key * add unit test for cmd type * unit test for key_type function * edit unit test test key_type after cargo fmt --all -- --check --------- Co-authored-by: MARONE <[email protected]>
This fixes a bug where 2 servers use the same port, because `get_random_available_port` is called before the first server manages to use its port. This should reduce test flakyness.
barshaul
approved these changes
Sep 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.