fix: .onConnectionEstablished() is fired twice after invoking .connect(); closes 124 #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencerlepine
requested review from
haomingli2020 and
mrajatttt
and removed request for
a team
spencerlepine
changed the title
spencerlepine
force-pushed
the
spenlep/issue-124
branch
from
09d4def to
bcf53ec
Compare
spencerlepine
force-pushed
the
spenlep/issue-124
branch
from
bcf53ec to
3ee613d
Compare
mrajatttt
approved these changes
Oct 3, 2023
haomingli2020
approved these changes
Mar 4, 2024
This was referenced Aug 7, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#124
Description of changes:
fix: .onConnectionEstablished() is fired twice after invoking .connect()
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.