Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added lightbox2 functionality complete with an example (project_10) #2692

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Picsiri
Copy link

@Picsiri Picsiri commented Sep 12, 2024

No description provided.

@george-gca
Copy link
Collaborator

What is this for?

@Picsiri
Copy link
Author

Picsiri commented Sep 13, 2024

What is a feature for? Anything you use it for.

I mostly needed it where I put 12 images in a row. With this you can actually see all of them. Also, in general I like if an image pops up when I click on it.

I am not sure about it but I guess imagemagick downscales the embedded images? In that case pop up does not enlarge the image but if you upload HD images...

@george-gca
Copy link
Collaborator

What is a feature for? Anything you use it for.

With this you assume we know what lightbox is for.

I mostly needed it where I put 12 images in a row. With this you can actually see all of them. Also, in general I like if an image pops up when I click on it.

Do you have a working example or screenshots? In this example the zoomable images pops when you click on them.

I am not sure about it but I guess imagemagick downscales the embedded images?

Not entirely sure, but I believe this is only currently happening on publication images like reported in #2668.

@Picsiri
Copy link
Author

Picsiri commented Sep 16, 2024

Oh, so the question was made in the contect of not knowing anything about this PR, now I get it :)

Well, here is lightbox2.

And an example is provided in 10_project. Basically the same as in the link above. Only this is integrated into alfolio.

I haven't seen the data-zoomable tag feature. Still this is a bit "more" than that as you can group images and navigate between them if you think they belong together.

Also, the images can be annotated.

@Picsiri
Copy link
Author

Picsiri commented Sep 28, 2024

Should I cancel the PR?

@george-gca
Copy link
Collaborator

Not needed. I will give it a look as soon as I can.

@alshedivat
Copy link
Owner

just catching up here: what's the advantage of lightbox2 over zoomable images we already have?

@alshedivat alshedivat changed the base branch from master to main October 20, 2024 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants