Use presenter for confirmation text #9717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pezholio
force-pushed
the
content-modelling/use-presenter-for-confirmation-text
branch
4 times, most recently
from
577b742 to
8acfa05
Compare
Harriethw
reviewed
Dec 10, 2024
...es/content_block_manager/app/presenters/content_block_manager/confirmation_copy_presenter.rb
Outdated
Show resolved
Hide resolved
Harriethw
reviewed
Dec 10, 2024
lib/engines/content_block_manager/features/step_definitions/content_block_manager_steps.rb
Show resolved
Hide resolved
pezholio
force-pushed
the
content-modelling/use-presenter-for-confirmation-text
branch
from
8acfa05 to
d7cedb1
Compare
This makes the logic easier to test
This makes testing easier and DRYs things up
pezholio
force-pushed
the
content-modelling/use-presenter-for-confirmation-text
branch
from
d7cedb1 to
ee7a59a
Compare
Harriethw
approved these changes
Dec 10, 2024
pezholio
deleted the
content-modelling/use-presenter-for-confirmation-text
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #9702 (comment) this adds a new presenter class to make the confirmation text a bit more testable