(763) Fix mainstream preview bug within guide chapters #9715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pezholio
force-pushed
the
content-modelling/763-bug-mainstream-preview-bug-within-guide-chapters
branch
3 times, most recently
from
48f4709 to
b642480
Compare
pezholio
force-pushed
the
content-modelling/763-bug-mainstream-preview-bug-within-guide-chapters
branch
from
b642480 to
fabc819
Compare
This ensures that any local links that we click on within the frame reload the host content endpoint with a param pointing to the original path. In the next commit, we’ll allow that path to be optionally loaded
This allows custom paths to be passed in and loaded when a user clicks on a link within a preview.
This will allow any local pages (e.g. multi-page guides etc) to be rendered via the `GetPreviewContent` service
In some circumstances (such as guides), instances can be over multiple pages, so we can’t reliably get the number of instances from the preview, so we need to get the metadata directly from the Publishing API
pezholio
force-pushed
the
content-modelling/763-bug-mainstream-preview-bug-within-guide-chapters
branch
from
fabc819 to
d8c2cad
Compare
pezholio
deleted the
content-modelling/763-bug-mainstream-preview-bug-within-guide-chapters
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card: https://trello.com/c/WZvzmuMI/763-bug-mainstream-preview-bug-within-guide-chapters
This fixes the issue when previewing content types with multiple pages by updating all relative links to link to the preview page with the path added as a query string, allowing any content to be parsed via the
GetPreviewContentservice.Additionally, because we can't reliably get all the instances within a document when parsing the content randomly, I've updated the call to
instancesto fetch the instance count via the Publishing API (PR here alphagov/publishing-api#3030) rather than relying on the count on the current preview page.This can't be merged until alphagov/publishing-api#3030 is merged