Prevent navigation events from being tracked on tab controls #9711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would be preferable to use the role ARIA attribute to do this, but it's not present yet when this module is initialised. This is because component modules are initialised after analytics and the tabs component is responsible for adding the role via javascript during its initialisation. Analytics modules are initialised before components by GOV.UK Publishing components.
minhngocd
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be preferable to use the role ARIA attribute to do this, but it's not present yet when this module is initialised. This is because component modules are initialised after analytics and the tabs component is responsible for adding the role via javascript during its initialisation. Analytics modules are initialised before components by GOV.UK Publishing components.
Trello: https://trello.com/c/mVJGdWsZ