(699) Allow Content Block schedule to be edited #9699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pezholio
force-pushed
the
content-modelling/699-allow-schedule-to-be-edited
branch
6 times, most recently
from
2d87531 to
ef4340b
Compare
pezholio
changed the title
These methods are no longer shared, so it doesn’t make sense to have them in a module
This will allow the schedule to be edited
This will allow users to publish any previously scheduled editions immediately
This will allow us to use this behaviour in another controller in the next commit
This adds a new controller to edit a schedule, acting directly on the document. This fetches the document and acts on the latest edition. I’ve also updated some of the feature tests to use a tag to enable/disable Sidekiq, so we can share the features more easily.
If an editor has a scheduled edition awaiting publication and goes through the whole edit flow to create a new edition, we need to ensure that any scheduled editions are superseded.
pezholio
force-pushed
the
content-modelling/699-allow-schedule-to-be-edited
branch
from
ef4340b to
46e10b9
Compare
Harriethw
reviewed
Dec 5, 2024
| @@ -28,6 +30,7 @@ def publish_with_rollback(content_block_edition) | |||
| }, | |||
| ) | |||
| ContentBlockManager::SchedulePublishingWorker.dequeue(content_block_edition) if content_block_edition.scheduled? | |||
There was a problem hiding this comment.
ContentBlockManager::SchedulePublishingWorker.dequeue(content_block_edition) if content_block_edition.scheduled?
do you think this line could be part of the dequeuing concern? or is the dequeuing concern already doing this?
There was a problem hiding this comment.
or could it have it's own named function to show what it's doing like dequeue_current_edition_if_previously_scheduled
There was a problem hiding this comment.
Good plan! Have done 👍
This seems like a nicely logical place for this behaviour, and DRYs things up a bit more.
Harriethw
approved these changes
Dec 5, 2024
pezholio
deleted the
content-modelling/699-allow-schedule-to-be-edited
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an "Edit" button to a previously scheduled content block, allowing the schedule to be changed prior to the scheduled publication happening.
It also adds the ability to supersede previously scheduled editions when a new edition is published or scheduled before any previously scheduled edition(s) have been published.
Screenshot
Trello cards: https://trello.com/c/nYOtTtr2/699-update-view-page https://trello.com/c/BPc2NY8s/755-dequeue-scheduled-editions-when-publishing-a-new-edition