show errors if confirm not checked on review page #9697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harriethw
force-pushed
the
content-modelling/719-with-checkbox-confirm-error
branch
from
0e1fceb to
5e69626
Compare
pezholio
reviewed
Dec 4, 2024
| @@ -61,6 +61,7 @@ def edit_draft | |||
|
|
|||
| def review | |||
| @content_block_edition = ContentBlockManager::ContentBlock::Edition.find(params[:id]) | |||
| @review_errors = [REVIEW_ERROR.new(attribute: "is_confirmed", full_message: "Confirm details are correct")] | |||
| def publish | ||
| if params[:step] == NEW_BLOCK_STEPS[:review] && params[:is_confirmed].blank? | ||
| raise StandardError |
There was a problem hiding this comment.
Do we need to raise here? Could we not just have the code from line 132 and down inside the conditional, and then wrap the happy path in an else?
There was a problem hiding this comment.
true! I guess it doesn't have to be an error, have turned into an if statement
Harriethw
force-pushed
the
content-modelling/719-with-checkbox-confirm-error
branch
2 times, most recently
from
5d30ead to
796bd53
Compare
Because this is not an active record error we have to have some custom behaviour here. Currently the review page is only shown for the create/new journey, so have checked we are on the 'new' step here.
Harriethw
force-pushed
the
content-modelling/719-with-checkbox-confirm-error
branch
from
796bd53 to
00c6b19
Compare
pezholio
approved these changes
Dec 5, 2024
| assert_text "Email address scheduled to publish on #{@future_date.strftime('%e %B %Y%l:%M%P').strip}" | ||
| assert_text "Email address scheduled to publish on #{@future_date.strftime('%e %B %Y %l:%M%P')}" |
There was a problem hiding this comment.
I think let's just remove the date altogether here - it makes sense to not have our feature tests so specific
this was causing tests to be flakey because sometimes it would format with the space padded before time, sometimes without. https://gds.slack.com/archives/C0776B04EJU/p1733396809325189
Harriethw
force-pushed
the
content-modelling/719-with-checkbox-confirm-error
branch
from
00c6b19 to
1252dd2
Compare
Harriethw
deleted the
content-modelling/719-with-checkbox-confirm-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE: Unless between 11:30-14:00
Because this is not an active record error we have to have some custom behaviour here. Not sure if this is the best way!
Currently the review page is only shown for the create/new journey, so have checked we are on the 'new' step here.
mural
code
Follow these steps if you are doing a Rails upgrade.