Content modelling/735 homepage date filter #9680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harriethw
force-pushed
the
content-modelling/735-homepage-date-filter
branch
from
b9aec5d to
fa60e10
Compare
Harriethw
commented
Nov 29, 2024
...app/models/content_block_manager/content_block/document/scopes/searchable_by_updated_date.rb
Outdated
Show resolved
Hide resolved
pezholio
force-pushed
the
content-modelling/735-homepage-date-filter
branch
4 times, most recently
from
5a80e07 to
7ea4c00
Compare
pezholio
reviewed
Dec 10, 2024
...components/content_block_manager/content_block/document/index/date_filter_component.html.erb
Outdated
Show resolved
Hide resolved
...ent_block_manager/app/models/content_block_manager/content_block/document/document_filter.rb
Show resolved
Hide resolved
...ent_block_manager/app/models/content_block_manager/content_block/document/document_filter.rb
Show resolved
Hide resolved
...ent_block_manager/app/models/content_block_manager/content_block/document/document_filter.rb
Outdated
Show resolved
Hide resolved
pezholio
force-pushed
the
content-modelling/735-homepage-date-filter
branch
3 times, most recently
from
f0b0546 to
747c174
Compare
users should be able to filter by 'to' and 'from' last updated. I've diverged a bit here from the Whitehall editions filter (they have a free text input) as I think this is the more accesible form of inputs. Errors and default values to be added in future commits.
Here we join the editions by the latest_edition_id, and search by the updated date of the joined edition
More error handling to come, but for now if any of the fields are empty we do not accept it as a date.
here we use the component and scope to filter by last updated date. (error handling still to come)
passing the filters to the date component so it can check what its values should be.
If there are errors, we do the rest of the filters without the erroring ones, so as to return something helpful.
I’ve updated the feature specs to ensure each document has multiple editions to ensure the query works correctly
pezholio
force-pushed
the
content-modelling/735-homepage-date-filter
branch
from
747c174 to
912fed6
Compare
pezholio
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/auF0TsMT/735-update-homepage-add-last-updated-date-filter
Follow these steps if you are doing a Rails upgrade.