Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-select the current value for 'world location type' #9109

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

ChrisBAshton
Copy link
Contributor

Prior to this commit, the selected value would always default to "World location", which meant it was easy to accidentally change the world location type when making an edit to a "international delegation".

Trello: https://trello.com/c/GvXvAOvV/2655-fix-world-location-news-type-default-bug

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

@ChrisBAshton ChrisBAshton force-pushed the fix-dropdown-world-location-news branch from 38a214c to 8b6e07a Compare June 4, 2024 10:11
Prior to this commit, the selected value would always default to
"World location", which meant it was easy to accidentally change
the world location type when making an edit to a "international
delegation".

Trello: https://trello.com/c/GvXvAOvV/2655-fix-world-location-news-type-default-bug
@ChrisBAshton ChrisBAshton force-pushed the fix-dropdown-world-location-news branch from 8b6e07a to 148ffa5 Compare June 4, 2024 10:13
@ChrisBAshton ChrisBAshton marked this pull request as ready for review June 4, 2024 10:20
Copy link
Contributor

@ryanb-gds ryanb-gds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐛 🔨

@ChrisBAshton ChrisBAshton merged commit bc17916 into main Jun 4, 2024
19 checks passed
@ChrisBAshton ChrisBAshton deleted the fix-dropdown-world-location-news branch June 4, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants