Allow Better Errors to work with Docker #9100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that, in some circumstances, error traces were showing in plaintext when using Whitehall in Docker. After some research I found [this issue][1], the solution for which allows the host machine, Docker and Better Errors to play together nicely! [1]: BetterErrors/better_errors#270
yndajas
approved these changes
May 31, 2024
|
It's cool that you've fixed it, however I would ask do we really want better_errors? It's been broken a long time so it's a dependency that can probably be shed for simplification of the project - and I really don't think it's a part of anyone's workflow for the app. |
|
@kevindew - I totally get that, but I have found it useful when doing spikes / exploration. It might be worth flagging it for future discussion, but it'd be good if we could keep it around for now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that, in some circumstances, error traces were showing in plaintext when using Whitehall in Docker. After some research I found this issue, the solution for which allows the host machine, Docker and Better Errors to play together nicely!