Abstract republishing_all controller action
#9090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brucebolt
approved these changes
May 30, 2024
Gweaton
approved these changes
May 30, 2024
In writing the next bulk republishing 'all' action (all documents), it became evident that only two lines needed changing. We'll have six or seven of these, so this abstracts the action and related code so we can keep things DRY A minor change has been applied to the (already abstract) `confirm_all` action to keep the code and naming more similar between the two actions for easy comparison This change makes the `metadata` name feel more wrong: having a lambda/method in metadata feels a bit wrong. One to think about
yndajas
force-pushed
the
1167-abstract-republish-all-action
branch
from
301aba9 to
83d87e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello (groundwork)
In writing the next bulk republishing 'all' action (all documents), it became evident that only two lines needed changing. We'll have six or seven of these, so these abstracts the action and related code so we can keep things DRY
A minor change has been applied to the (already abstract)
confirm_allaction to keep the code and naming more similar between the two actions for easy comparisonThis change makes the
metadataname feel more wrong: having a lambda/method in metadata feels a bit wrong. One to think aboutFollow these steps if you are doing a Rails upgrade.