Prevent long Nation Inapplicability Alternative URLs from breaking the database transaction

[minhngocd]

URLs which are longer than 255 characters break the database limit, so we are introducing a character limit for URLs to prevent this from happening. Users should seek to shorten their URLs.

https://trello.com/c/CPM8XMsf

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

[minhngocd]

Error message content might need a review

[ryanb-gds]

I have a suggestion on the message. My suspicion is we might wait a while for content review. I don't like that the message starts with the field name which is not the same as the label either. We could avoid that by putting the message in a locale file, which might be nice

[minhngocd]

@ryanb-gds updated with your suggestions and also updated the screenshots to reflect 👍

[minhngocd]

@ryanb-gds Managed to change the humanised version of the attribute so it should read better (updated screenshot).

The only gripe now is the anchor link doesn't quite take you to the field because of the attribute id being coded into the view, and the error summary component not having any connection to this so will not know which of the 3 fields to link to.

Could override the href so that if it is related to Nation Inapplicability alternative URL to just send it to Excluded Nations field anchor instead. but this would create an exceptional case in Error Summary Component which would be ugly. Open to suggestions or i think we could just call it functional enough here.

[ryanb-gds]

@ryanb-gds Managed to change the humanised version of the attribute so it should read better (updated screenshot).

The only gripe now is the anchor link doesn't quite take you to the field because of the attribute id being coded into the view, and the error summary component not having any connection to this so will not know which of the 3 fields to link to.

Could override the href so that if it is related to Nation Inapplicability alternative URL to just send it to Excluded Nations field anchor instead. but this would create an exceptional case in Error Summary Component which would be ugly. Open to suggestions or i think we could just call it functional enough here.

🤯

I think it's probably functional enough? Having tested this on the current codebase the link for the alternative URL field in the error summary doesn't actually work anyway. Rails and conditional fields are not friends

[ryanb-gds]

Thanks for picking this up ⭐