Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release and code cleanup header navigation #8447

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

farahTW
Copy link
Contributor

@farahTW farahTW commented Nov 2, 2023

This PR prepares header navigation for release and remove legacy code.
It does the following

  • Update header partial to have design system content.
  • Update design layout view to always render new header.
  • remove legacy tests for header navigation.
  • Update New Document controller to render design system.
  • Update More controller to render design system.

Trello:
https://trello.com/c/WsD20PgJ/574-prepare-release-code-cleanup-for-header-navigation

@mtaylorgds mtaylorgds force-pushed the prepare_release_and_code_cleanup_header_navigation branch from 1b33591 to 40a170b Compare November 3, 2023 14:12
@farahTW farahTW force-pushed the prepare_release_and_code_cleanup_header_navigation branch from 40a170b to ea0a5e7 Compare November 3, 2023 14:23
@farahTW
Copy link
Contributor Author

farahTW commented Nov 3, 2023

As discussed we are keeping legacy_header view , associated styles and methods in url helper file till we do a final clean up for “admin” layout, which is out of scope of this card.
@minnodang1 @marktaylor49 @davidtrussler4

@farahTW farahTW force-pushed the prepare_release_and_code_cleanup_header_navigation branch from ea0a5e7 to 67eca7f Compare November 3, 2023 16:50
Copy link
Contributor

@RodneyJohnsonGDS RodneyJohnsonGDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me, good work on this team!

@minhngocd minhngocd force-pushed the prepare_release_and_code_cleanup_header_navigation branch from 67eca7f to 5e8c3e6 Compare November 21, 2023 16:33
@minhngocd minhngocd force-pushed the prepare_release_and_code_cleanup_header_navigation branch from 5e8c3e6 to 28fa052 Compare November 21, 2023 17:23
@farahTW farahTW merged commit ea25dab into main Nov 22, 2023
15 checks passed
@farahTW farahTW deleted the prepare_release_and_code_cleanup_header_navigation branch November 22, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants