Disable remove_previously_stored_files_after_update #8444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This config disables the default carrierwave behaviour of deleting previous images on update. The issue with removing previous images is that the documents using them may have associations that also use the images. Therefore, when the images get deleted from asset-manager, the associated published documents will 404 for the image, unless an intentional update is run to inform the association that a new image has been provided. Such an example is Speech document and the relates Person who made the speech. Speech page shows the image of the person. When Person updates the picture, Speech needs to be republished as well, otherwise it will try to show the old image (404 if deletion enabled).
lauraghiorghisor-tw
force-pushed
the
do-not-remove-previously-stored-images
branch
from
a5fb04a to
dc4a683
Compare
tunylund
approved these changes
Nov 2, 2023
lauraghiorghisor-tw
deleted the
do-not-remove-previously-stored-images
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This config disables the default carrierwave behaviour of deleting previous images on update.
The issue with removing previous images is that the documents using them may have associations that also use the images. Therefore, when the images get deleted from asset-manager, the associated published documents will 404 for the image, unless an intentional update is run to inform the association that a new image has been provided.
Such an example is Speech document and the related Person who made the speech. Speech page shows the image of the person. When Person updates the picture, Speech needs to be republished as well, otherwise it will try to show the old image (404 if deletion enabled).