Allow WWOrganisation to use FeaturedImageData #8443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuetylauiris
force-pushed
the
move-worldwideorganisation-to-assets
branch
from
fb98fd0 to
38247ea
Compare
syed-ali-tw
force-pushed
the
move-worldwideorganisation-to-assets
branch
from
38247ea to
28b1337
Compare
yuetylauiris
force-pushed
the
move-worldwideorganisation-to-assets
branch
2 times, most recently
from
1c58021 to
feedc80
Compare
syed-ali-tw
force-pushed
the
move-worldwideorganisation-to-assets
branch
3 times, most recently
from
5eeb3ee to
c481d62
Compare
tunylund
reviewed
Nov 6, 2023
syed-ali-tw
force-pushed
the
move-worldwideorganisation-to-assets
branch
3 times, most recently
from
39ca8c3 to
5690e7d
Compare
syed-ali-tw
force-pushed
the
move-worldwideorganisation-to-assets
branch
from
5690e7d to
120af52
Compare
syed-ali-tw
force-pushed
the
move-worldwideorganisation-to-assets
branch
from
120af52 to
c6801c5
Compare
tunylund
approved these changes
Nov 6, 2023
This Change makes WWOrganisation use Asset manager ids instead of legacy url path for WWOrganisation default news images. This should make things more consistent across these classes. Co-authored-by: Iris Lau <[email protected]>
syed-ali-tw
force-pushed
the
move-worldwideorganisation-to-assets
branch
from
c6801c5 to
6b86687
Compare
syed-ali-tw
added a commit
that referenced
this pull request
Nov 7, 2023
…ImageData from WorldwideOrganisations This is a side-effect from #8443
syed-ali-tw
added a commit
that referenced
this pull request
Nov 7, 2023
…ImageData from WorldwideOrganisations This is a side-effect from #8443
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Change makes WorldwideOrganisation use Asset manager ids instead of legacy url path for WorldwideOrganisation default news images. It also shifts the responsiblity for Image configuration into an intermediate class FeaturedImageData which is used for all similar use cases in whitehall. This should make things more consistent across these classes.
Trello Card