Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created sub-navigation component with design system to whitehall. #8400

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

farahTW
Copy link
Contributor

@farahTW farahTW commented Oct 23, 2023

This PR creates sub-navigation component in whitehall code base similar to the moj component mentioned at the below link
https://design-patterns.service.justice.gov.uk/components/primary-navigation/

This component is required to transit sub navigation bar to design system with main header layout in Whitehall.
This will be available to use as a sub navigation bar for header layout.

Screen shot:
image

Component url
http://whitehall-admin.dev.gov.uk/component-guide/sub_navigation#

Trello:
https://trello.com/c/sVAtLYAa/583-create-subnavigation-component-in-whitehall

@farahTW farahTW force-pushed the 583-create-subnavigation-component branch 4 times, most recently from 1d4cc6c to bc5c7b2 Compare October 24, 2023 14:17
@farahTW
Copy link
Contributor Author

farahTW commented Oct 24, 2023

Hi @nnagewad
As discussed, we have updated the design while we select any nav item to show underlined.

Updated screen shots:
image
image

@farahTW farahTW force-pushed the 583-create-subnavigation-component branch from bc5c7b2 to 213505c Compare October 24, 2023 14:35
@nnagewad
Copy link
Contributor

This looks incredible! Great job @farahTW + @davidtrussler 👍🏽

@farahTW farahTW force-pushed the 583-create-subnavigation-component branch from 213505c to 550c561 Compare October 24, 2023 16:37
@farahTW farahTW merged commit a29e60d into main Oct 25, 2023
15 checks passed
@farahTW farahTW deleted the 583-create-subnavigation-component branch October 25, 2023 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants