Add rake task to report on a regex in editionable content #8397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brucebolt
force-pushed
the
add-report-rake
branch
2 times, most recently
from
0f87fa2 to
3d370a9
Compare
Sometimes we want to identify which published content matches a regular expression (e.g. if we make a change to govspeak and need to republish affected content). Therefore adding a rake task that will report on the content that includes a given regex in the currently published edition. This is being broken down into batches of 1000, as our infrastructure does not support large queries being made on a Rails console.
brucebolt
force-pushed
the
add-report-rake
branch
from
3d370a9 to
86f4210
Compare
jkempster34
approved these changes
Oct 23, 2023
| end | ||
|
|
||
| test "it prints the content IDs of the matching documents from published editions" do | ||
| assert_output(/#{@document_1.document.content_id}/) { Rake.application.invoke_task "reporting:matching_docs[Some text]" } |
There was a problem hiding this comment.
I wondered if these could not use regex like assert_output(@document_1.document.content_id) { Rake.application.invoke_task "reporting:matching_docs[Some text]" }, but I don't know if there is a way to do contains
There was a problem hiding this comment.
Yeah, I couldn't find an equivalent method that didn't require a regex.
| task :matching_docs, [:regex] => :environment do |_, args| | ||
| regex = Regexp.new(/#{args[:regex]}/) | ||
|
|
||
| Document.where.not(live_edition_id: nil).find_in_batches(batch_size: 1000) do |batch| |
There was a problem hiding this comment.
I saw on the Trello card that you were investigating other tables, are there none?
There was a problem hiding this comment.
I've constrained this PR to just the editionable documents. I was going to raise in today's stand-up what the scope of the spike is, as I've already hit the 2 days on the ticket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we want to identify which published content matches a regular expression (e.g. if we make a change to govspeak and need to republish affected content).
Therefore adding a rake task that will report on the content that includes a given regex in the currently published edition.
This is being broken down into batches of 1000, as our infrastructure does not support large queries being made on a Rails console.
Trello card