Merge pull request #9094 from alphagov/phone-number-deletion-two

'Refactor' of Delete blank contacts function
alphagov · May 31, 2024 · 23902fa · 23902fa
2 parents cd622b0 + 2d5fd5d
commit 23902fa
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/app/controllers/admin/worldwide_offices_controller.rb b/app/controllers/admin/worldwide_offices_controller.rb
@@ -21,8 +21,8 @@ def update
 
     update_params[:service_ids] ||= []
 
-    if update_params.dig(:contact_attributes, :contact_numbers_attributes)
-      update_params.dig(:contact_attributes, :contact_numbers_attributes).each do |_id, contact_number_attribute|
+    if (contact_numbers_attributes = update_params.dig(:contact_attributes, :contact_numbers_attributes))
+      contact_numbers_attributes.each do |_id, contact_number_attribute|
         contact_number_attribute[:_destroy] = true if contact_number_attribute[:label].empty? && contact_number_attribute[:number].empty?
       end
     end