Use 'select_content' event name for buttons which don't trigger a for…

…m submission It doesn't make sense to track a "navigation" event for such buttons, as there is no form submission to trigger a page navigation
alphagov · Dec 6, 2024 · 01b40b1 · 01b40b1
1 parent 6b00ce8
commit 01b40b1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/app/assets/javascripts/admin/analytics-modules/ga4-button-setup.js b/app/assets/javascripts/admin/analytics-modules/ga4-button-setup.js
@@ -13,7 +13,8 @@ window.GOVUK.analyticsGa4.analyticsModules =
         const buttons = moduleElement.querySelectorAll('button')
         buttons.forEach((button) => {
           const event = {
-            event_name: 'navigation',
+            event_name:
+              button.type === 'submit' ? 'navigation' : 'select_content',
             type: 'button',
             text: button.textContent
           }

diff --git a/spec/javascripts/admin/analytics-modules/ga4-button-setup.spec.js b/spec/javascripts/admin/analytics-modules/ga4-button-setup.spec.js
@@ -18,7 +18,7 @@ describe('GOVUK.analyticsGa4.analyticsModules', function () {
     ga4ButtonSetup.init()
 
     expect(button.dataset.ga4Event).toEqual(
-      '{"event_name":"navigation","type":"button","text":"Button"}'
+      '{"event_name":"select_content","type":"button","text":"Button"}'
     )
   })