Fixes to appease rubocop

alphagov · Dec 29, 2023 · 24ebbef · 24ebbef
1 parent 6c85efe
commit 24ebbef
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/app/workers/content_item_populate_doctype_worker.rb b/app/workers/content_item_populate_doctype_worker.rb
@@ -5,7 +5,7 @@ def perform
     content_store = GdsApi::ContentStore.new(Plek.find("content-store"))
     document_type_errors = []
 
-    ContentItem.all.each do |content_item|
+    ContentItem.find_each do |content_item|
       found_content_item = content_store.content_item(content_item.path)
 
       document_type = found_content_item["document_type"]

diff --git a/spec/workers/content_item_populate_doctype_worker_spec.rb b/spec/workers/content_item_populate_doctype_worker_spec.rb
@@ -6,7 +6,7 @@
 
   it "updates every content item's `document_type`" do
     content_item = double("ContentItem", path: "foo")
-    allow(ContentItem).to receive(:all).and_return([content_item])
+    allow(ContentItem).to receive(:find_each).and_yield(content_item)
     mock_content_store = double("ContentStore", content_item: { "document_type" => "foo_doctype" })
     allow(GdsApi::ContentStore).to receive(:new).and_return(mock_content_store)