Add GA4 form tracker and section value to survey banner #3158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
section
value to the GA4 object for the survey banner events, with the value ofsection
being the survey's heading text.form_complete
event usingGa4AutoTracker
when the survey is sent to the user. This adds a<span>
to the DOM with GA4 auto on it, rather than adding GA4 code tosurveys.js
. I thought this would be better as it prevents us adding a bunch of GA4 code in static which checks if GA4 modules exists, if cookie consent exists, and then more code to push the event. Instead we add a<span>
with the auto tracker on it, then runwindow.GOVUK.Modules.start()
.Why
How to test
surveys.js
go to the functionisSurveyToBeDisplayed
and set it to just return true, e.g.:gem_base.html.erb
, add the HTML element somewhere: