Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove disused NPM versions file. #1500

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Remove disused NPM versions file. #1500

merged 1 commit into from
Jun 24, 2024

Conversation

sengi
Copy link
Contributor

@sengi sengi commented Jun 24, 2024 •
edited
Loading

We build with Yarn and not npm, so it's just confusing to have two lockfiles that refer to the same packages.

@sengi
Remove disused NPM versions file.
ed6bdd2 
We build with Yarn and not npm, so it's just confusing to have two
lockfiles.
@sengi sengi requested a review from theseanything June 24, 2024 16:35
dj-maisy
dj-maisy approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@dj-maisy dj-maisy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💣

@sengi sengi merged commit dfbf48b into main Jun 24, 2024
11 checks passed
@sengi sengi deleted the sengi/rm-old-npm-lockfile branch June 24, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dj-maisy dj-maisy dj-maisy approved these changes

@theseanything theseanything Awaiting requested review from theseanything

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sengi @dj-maisy