Remove HTTParty and use Faraday throughout. #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need two different HTTP client libraries. Faraday is a more capable library, more actively maintained and already a transitive dependency via Octokit, so let's drop HTTParty. As a bonus, this also gets rid of the questionably-tasteful post-install message.
This was making it unnecessarily difficult to run the tests locally.
Also avoid `XXX` since that's commonly used as a no-merge/no-commit marker.
sengi
force-pushed
the
sengi/end-of-the-HTTParty
branch
from
1f74090 to
4c63a5b
Compare
theseanything
approved these changes
Jun 25, 2024
Also, interpret empty `SLACK_WEBHOOK_URL` the same as not set / nil.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need two different HTTP client libraries. Faraday is a more capable library, more actively maintained and already a transitive dependency via Octokit, so let's drop HTTParty.
This eliminates four third-party dependencies:
httparty,csv,mini_mime,multi_xml.As a bonus, we also lose the controversial post-install message that the maintainer of HTTParty refuses to drop.