Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rails from 7.1.1 to 7.1.2 #1322

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 13, 2023

Bumps rails from 7.1.1 to 7.1.2.

Release notes

Sourced from rails's releases.

7.1.2

Active Support

  • Fix :expires_in option for RedisCacheStore#write_multi.

    fatkodima

  • Fix deserialization of non-string "purpose" field in Message serializer

    Jacopo Beschi

  • Prevent global cache options being overwritten when setting dynamic options inside a ActiveSupport::Cache::Store#fetch block.

    Yasha Krasnou

  • Fix missing require resulting in NoMethodError when running bin/rails secrets:show or bin/rails secrets:edit.

    Stephen Ierodiaconou

  • Ensure {down,up}case_first returns non-frozen string.

    Jonathan Hefner

  • Fix #to_fs(:human_size) to correctly work with negative numbers.

    Earlopain

  • Fix BroadcastLogger#dup so that it duplicates the logger's broadcasts.

    Andrew Novoselac

  • Fix issue where bootstrap.rb overwrites the level of a BroadcastLogger's broadcasts.

    Andrew Novoselac

  • Fix ActiveSupport::Cache to handle outdated Marshal payload from Rails 6.1 format.

    Active Support's Cache is supposed to treat a Marshal payload that can no longer be deserialized as a cache miss. It fail to do so for compressed payload in the Rails 6.1 legacy format.

    Jean Boussier

  • Fix OrderedOptions#dig for array indexes.

    fatkodima

... (truncated)

Commits
  • 6b93fff Preparing for 7.1.2 release
  • 200749d Sync CHANGELOG
  • cceb111 Add CHANGELOG entry for 3e8f1e0aeb81bacddf5a4d29ee3019ad8cc4681a [ci-skip]
  • 3e8f1e0 Merge pull request #49998 from fatkodima/fix-pg-rename_table-with-uuid-pk
  • 826e9a0 Merge pull request #49692 from mguan2020/branchi
  • 122967f Merge pull request #49997 from y0608/patch-1
  • fe1a9b7 Merge pull request #49839 from skipkayhil/hm-skb-deprecation
  • 28deb8b Merge pull request #49050 from JohnAnon9771/fix/issue-48535
  • fb96a02 Merge pull request #49989 from cjilbert504/preposition-fix-fields-for-comments
  • 6ef5e07 Merge pull request #49988 from skipkayhil/hm-fix-db-change-no-docker
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [rails](https://github.com/rails/rails) from 7.1.1 to 7.1.2.
- [Release notes](https://github.com/rails/rails/releases)
- [Commits](rails/rails@v7.1.1...v7.1.2)

---
updated-dependencies:
- dependency-name: rails
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies ruby Pull requests that update Ruby code labels Nov 13, 2023
Copy link

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

@MuriloDalRi MuriloDalRi force-pushed the dependabot/bundler/rails-7.1.2 branch 6 times, most recently from e4bd988 to 2816fcf Compare November 15, 2023 15:16
@MuriloDalRi MuriloDalRi force-pushed the dependabot/bundler/rails-7.1.2 branch from 2816fcf to 9d61987 Compare November 17, 2023 13:36
@MuriloDalRi MuriloDalRi merged commit 80f6c93 into main Nov 21, 2023
9 checks passed
@MuriloDalRi MuriloDalRi deleted the dependabot/bundler/rails-7.1.2 branch November 21, 2023 13:02
# Please, add to the `ignore` list any other `lib` subdirectories that do
# not contain `.rb` files, or that should not be reloaded or eager loaded.
# Common ones are `templates`, `generators`, or `middleware`, for example.
config.autoload_lib(ignore: %w[assets tasks])
Copy link
Contributor

@sengi sengi Nov 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line breaks the app completely.

bundle install && \
  RAILS_ENV=production GOVUK_APP_DOMAIN= GOVUK_WEBSITE_ROOT= SECRET_KEY_BASE=x \
  bundle exec rails s
...
=> Rails 7.1.2 application starting in production
=> Run `bin/rails server --help` for more startup options
Exiting
/Users/sengi/src/alphagov/release/lib/report/deploy_lag_report.rb:1:in `<main>': Report is not a class (TypeError)
/Users/sengi/src/alphagov/release/vendor/bundle/ruby/3.1.0/gems/zeitwerk-2.6.12/lib/zeitwerk/loader/callbacks.rb:56: previous definition of Report was here
...

Same thing in integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants