Merge pull request #1287 from alphagov/fix-version-header

Fix release SHA in footer
alphagov · Sep 20, 2023 · 2084350 · 2084350
2 parents 7bc0672 + 887a079
commit 2084350
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb
@@ -27,7 +27,9 @@
     <%= yield %>
   </main>
 
-  <p class="govuk-body-s">Version: <%= CURRENT_RELEASE_SHA %></p>
+  <% if !CURRENT_RELEASE_SHA.nil? %>
+    <p class="govuk-body-s">Version: <%= CURRENT_RELEASE_SHA %></p>
+  <% end %>
 </div>
 
   <%= render "govuk_publishing_components/components/layout_footer", {} %>

diff --git a/config/initializers/current_release_sha.rb b/config/initializers/current_release_sha.rb
@@ -1,6 +1 @@
-if Rails.root.join("REVISION").exist?
-  revision = File.read(Rails.root.join("REVISION")).chomp
-  CURRENT_RELEASE_SHA = revision[0..10] # Just get the short SHA
-else
-  CURRENT_RELEASE_SHA = "development".freeze
-end
+CURRENT_RELEASE_SHA = `git rev-parse HEAD`.chomp[0..10] # Just get the short SHA