Include mapping between csv headers and the fields used in app #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heathd
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
not ideal that the required headers are duplicated in the validation function but it's ok, this isn't a super complicated piece of code.
We could probably avoid that by refactoring to put the validation and mapping logic in the same class, but I don't want to create lots of re-work so let's get this merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a mapping, so if the headers of the cost centre csv are changed, we only have to update them in the csv_updater script, and not in other places in the codebase.
The file uploaded to S3 now only contains the fields used by this app, instead of everything in the source csv.