Add fields to the request-an-aws-account tool to so that the new tags are populated on all new accounts #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redirect is now supplied by PaaS
Originally put in for billing but now it's not seen as helpful.
Co-authored-by: Hauwa Muhammad <[email protected]>
- Cost centre is only required for cabinet office and should redirect to summary screen (so user can check answers) - If cabinet office isn't selected should redirect to team page.
- so users can double check what the code they've entered references.
-varies on whether the org they have chosen is cabinet office or not.
Co-authored-by: Hauwa Muhammad <[email protected]>
- from s3 if COST_CENTRE_S3_BUCKET_NAME env var set. - saved to tmp folder which is ignored. Liits possibility of accidentally downloading the data from s3 and commiting it. - if not set it falls back to use the test fixture file with one fake cost centre.
Read the file into memory rather than writing it to a temp file. AppRunner doesn't make guarantees about local storage, in particular: > Storage – App Runner automatically scales the instances up or down for your App Runner application in accordance to incoming traffic volume. You can configure Auto scaling options for your App Runner application. Since the number of currently active instances processing the web requests is based on the incoming traffic volume, App Runner **cannot guarantee that the files can persist beyond the processing of a single request**. Hence, App Runner implements the file system in your container instance as ephemeral storage, which entails that the files are transient. For example, the files don't persist when you pause and resume your App Runner service. [source](https://docs.aws.amazon.com/apprunner/latest/dg/develop.html) Also changed the initializer so that it parses the CSV file during the initialization sequence. Tweaked the parser class and tests to accept a string rather than filename
heathd
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Eng-290
New screen looks like:
PR for CO account with cost centre
PR for GPA account without cost centre
