Yaml file for GHCR #281
Closed
Yaml file for GHCR #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tabroughton
suggested changes
Feb 5, 2024
| @@ -38,6 +38,6 @@ This is continuously deployed from master [by Github Actions](https://github.com | |||
|
|
|||
| To deploy to a separate route (e.g. for testing / previewing changes) you can push to PaaS manually: | |||
|
|
|||
| ``` | |||
| ```sh | |||
There was a problem hiding this comment.
pebble: do we need new details in the readme to describe the dockerfile and how to build/use it locally?
There was a problem hiding this comment.
Yes; that's still marked as to-do in ENG-83
| @@ -94,7 +94,7 @@ GEM | |||
| listen (3.8.0) | |||
| rb-fsevent (~> 0.10, >= 0.10.3) | |||
| rb-inotify (~> 0.9, >= 0.9.10) | |||
| lograge (0.12.0) | |||
| lograge (0.14.0) | |||
There was a problem hiding this comment.
grit: are all the dependencies updated/patched to address any security concerns etc or are they to get the devenv up and running only atm? (will we patch/address dependabot issues in another ticket?).
There was a problem hiding this comment.
The latter. Updating dependencies is separate in the backlog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.