Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get content by content id #2456

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Get content by content id #2456

merged 1 commit into from
Dec 11, 2024

Conversation

syed-ali-tw
Copy link
Contributor

@syed-ali-tw syed-ali-tw commented Dec 3, 2024

Trello

Implement an endpoint in Mainstream Publisher that takes a content ID as a parameter, and returns a redirect to the publications (search) page with the appropriate query parameters set.

Note that a route has already been created at /by-content-id/:content_id, which routes to the ContentItemController—this can be used as a starting point (this endpoint was created as part of the first attempt to fix the browser extension issue, and so is not currently in use and can safely be adapted)

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

Follow these steps if you are doing a Rails upgrade.

@syed-ali-tw syed-ali-tw force-pushed the browser-extension-fix branch 6 times, most recently from ebc3614 to 7488b66 Compare December 4, 2024 15:18
syed-ali-tw added a commit to alphagov/govuk-browser-extension that referenced this pull request Dec 5, 2024
We are going back to the changes in the PR we created originally
#212

This change is coupled with the changes we have made in Mainstream
alphagov/publisher#2456

These changes combined will support the old bootstrap ui and new design
system ui. Look up in mainstream will land user on publications page and
user will see same result to AS-IS for bootstrap ui.
@syed-ali-tw syed-ali-tw force-pushed the browser-extension-fix branch 3 times, most recently from 22157e9 to 3775923 Compare December 11, 2024 12:51
@syed-ali-tw syed-ali-tw force-pushed the browser-extension-fix branch from 3775923 to 460a565 Compare December 11, 2024 12:51
@syed-ali-tw syed-ali-tw merged commit 5dd2b9a into main Dec 11, 2024
12 checks passed
@syed-ali-tw syed-ali-tw deleted the browser-extension-fix branch December 11, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants