Add rake task to assign access permissions for an organisation #2422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tetrino
force-pushed
the
org-permissions-rake-task
branch
3 times, most recently
from
0884ceb to
8e71281
Compare
Four tasks are added that allow us to: - Assign and remove permissions on a case by case basis for specific artefacts - Remove all permission flags from an artefact, essentially resetting it to open permission - Assign an org permission to a group of artefacts from a CSV file containing rows of URLs There is no easy way to find the OrgID from an org name so OrgID must be provided by us when using it in the rake tasks.
Tetrino
force-pushed
the
org-permissions-rake-task
branch
from
8e71281 to
d1e2825
Compare
baisa
force-pushed
the
org-permissions-rake-task
branch
6 times, most recently
from
caddfeb to
b21951e
Compare
…rrecting save_as_task! syntax
baisa
force-pushed
the
org-permissions-rake-task
branch
from
b21951e to
24337a4
Compare
ellohez
force-pushed
the
org-permissions-rake-task
branch
2 times, most recently
from
3f1505e to
d9be641
Compare
ellohez
force-pushed
the
org-permissions-rake-task
branch
from
2bd86e8 to
df8c83c
Compare
- Logging allows us to gather a list of documents that cannot be found - Failure to find is typically because the path/slug has changed.
ellohez
force-pushed
the
org-permissions-rake-task
branch
from
df8c83c to
26a3320
Compare
mtaylorgds
reviewed
Nov 21, 2024
| if document.nil? | ||
| message = "Document ID #{args[:document_content_id]} not found, no permissions changed." | ||
| elsif document.latest_edition.owning_org_content_ids.include?(args[:org_content_id]) | ||
| message = "Organisation already has permission to access the document with ID - #{document.id}" |
There was a problem hiding this comment.
Is it worth capturing the org ID in the various log messages?
There was a problem hiding this comment.
Great idea! I have added this to the start of the log file - see line 29
There was a problem hiding this comment.
Since this rake task can be called independently of the bulk one, I think it might still be a good idea to include the org ID in the log messages here.
ellohez
force-pushed
the
org-permissions-rake-task
branch
2 times, most recently
from
e56afad to
9e6bdb8
Compare
|
Now working on Integration. |
mtaylorgds
reviewed
Nov 26, 2024
| if document.nil? | ||
| message = "Document ID #{args[:document_content_id]} not found, no permissions changed." | ||
| elsif document.latest_edition.owning_org_content_ids.include?(args[:org_content_id]) | ||
| message = "Organisation already has permission to access the document with ID - #{document.id}" |
There was a problem hiding this comment.
Since this rake task can be called independently of the bulk one, I think it might still be a good idea to include the org ID in the log messages here.
ellohez
force-pushed
the
org-permissions-rake-task
branch
from
9e6bdb8 to
37030c5
Compare
ellohez
force-pushed
the
org-permissions-rake-task
branch
from
37030c5 to
06a376e
Compare
mtaylorgds
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two tasks are added that allow us to:
There is no easy way to find the OrgID from an org name so OrgID must be provided by us when using it in the rake tasks.
https://trello.com/c/60RkKgwP/478-rake-task-to-set-owning-org-for-hmrc-content-mainstream
Follow these steps if you are doing a Rails upgrade.